Upgrade Next.js to v13 - Part I #5402
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| //sentry testing was causing OOM for some reason | ||
| //const { testkit, sentryTransport } = sentryTestkit(); | ||
| //global.testKit = testkit; | ||
| const { testkit } = sentryTestkit(); | ||
| global.testKit = testkit; |
There was a problem hiding this comment.
Their next upgrade was focused mostly on performance and reducing bundle size so my guess was the OOM was happening due to that.
| import { TFunction } from "i18n"; | ||
| import { StringMap, TOptions } from "i18next"; | ||
| import i18n from "test/i18n"; |
There was a problem hiding this comment.
They stopped exposing StringMap purposely (says in their docs). I tried to re-write this function but it was getting pretty gnarly, which is why I decided to just use the test instance of i18n in the tests and use the t function from there rather than mocking a separate one.
There was a problem hiding this comment.
I couldn't find any issues during testing. The only issue I encountered I think is unrelated to this PR:
Sending a request with a duration of over 1 year clears both dates AND clears the request message you typed (the entire text is deleted). This would really suck if you typed a long request:
Oh interesting but yeah that's unrelated let me throw that in another ticket here: #5432 |
Part 1 of the Next.js v13 upgrade. I will break this into two. This is doing the minimum to upgrade, which includes keeping some legacy behavior. The pages folder system will also be merged into the app folder and a lot of config will change. This version supports both ways. In part 2 I will change to new structure.
Migration Guide:
https://nextjs.org/docs/pages/building-your-application/upgrading/version-13
I needed to upgrade these packages as well for this:
This means you'll want to pay attention to translations and sentry while testing.
Web frontend checklist
yarn formatyarn lint --fix